On Fri, Jun 20, 2025 at 01:11:28PM +0200, Roger Pau Monne wrote: > +.PHONY: run > +run: $(TARGETS) > +ifeq ($(CC),$(HOSTCC)) > + for test in $? ; do \ > + ./$$test ; \ > + done
You need to add `set -e` or the exit value from the tested binary might be ignored. This `run` target only failed if the last test binary return a failure. > +else > + $(warning HOSTCC != CC, will not run test) > +endif > + > +.PHONY: clean > +clean: > + $(RM) -- *.o $(TARGETS) $(DEPS_RM) pdx.c pdx.h Is this "pdx.c" left over from version? It doesn't seems to be generated by this makefile. > + > +pdx.h: $(XEN_ROOT)/xen/include/xen/pdx.h > + sed -E -e '/^#[[:space:]]?include/d' <$< >$@ Why allow only zero or one space characters between '#' and "include"? Why not used '*' instead of '?' ? Thanks, -- Anthony PERARD
