On Tue, Jun 24, 2025 at 12:59:18PM +0100, Frediano Ziglio wrote:
> On Tue, Jun 24, 2025 at 12:57 PM Andrew Cooper
> <andrew.coop...@citrix.com> wrote:
> >
> > On 24/06/2025 12:45 pm, Frediano Ziglio wrote:
> > > The "buffer" macro is not defined.
> > >
> > > Fixes: 59e087bf6a9c ("xen/keyhandler: Drop keyhandler_scratch")
> > > Signed-off-by: Frediano Ziglio <frediano.zig...@cloud.com>
> > > Acked-by: Marek Marczykowski-Górecki <marma...@invisiblethingslab.com>
> >
> > While correct, the grammar isn't great. I'd suggest "Drop stale #undef
> > buffer" for the subject, and "The "buffer" macro was removed when
> > keyhandler_scratch was removed."
> >
>
> Fine for me.Fine with me too. > Not sure about the acknowledgement. > > > Can fix on commit. > > > > ~Andrew > > Frediano -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab
signature.asc
Description: PGP signature
