On 25.06.2025 12:16, Chen, Jiqian wrote: > On 2025/6/25 18:03, Jan Beulich wrote: >> Also, as said - you will need to check whether other architectures are >> different from x86-64 in this regard. We better wouldn't leave a trap here, >> for them to fall into when they enable vPCI support. I.e. my recommendation >> would be that if in doubt, we put the __aligned() there unconditionally. > That's difficult for me to check on all different platforms since I don't > have them all.
You don't need to have them. You'd need to carefully go through the respective section(s) of their psABI-s. > So you mean I should remove "#ifdef CONFIG_X86"? Just let __aligned(16) for > all platforms? Yes. And, as also said, with a suitable comment please. Jan