On 23.06.2025 22:20, dm...@proton.me wrote: > From: Denis Mukhin <dmuk...@ford.com> > > Introduce domain_console for grouping data structures used for integrating > domain's diagnostic console with Xen's console driver. > > Group all pbuf-related data structures under domain_console. Rename the moved > fields to plain .buf, .idx and .lock names, since all uses of the fields are > touched. > > Bump the domain console buffer size to the closest power of 2 (256) and > rename the symbol to DOMAIN_CONSOLE_BUF_SIZE. > > Finally, update the domain_console allocation and initialization code. > > No functional change. > > Signed-off-by: Denis Mukhin <dmuk...@ford.com> > --- > Changes since v3: > - parentheses fixup in guest_console_write() > - move buf to the end of domain_console
Plus do other re-arrangements there, if I'm not mistaken. > --- a/xen/common/domain.c > +++ b/xen/common/domain.c > @@ -669,7 +669,7 @@ static void _domain_destroy(struct domain *d) > BUG_ON(!d->is_dying); > BUG_ON(atomic_read(&d->refcnt) != DOMAIN_DESTROYED); > > - xfree(d->pbuf); > + xfree(d->console); This now needs to be xvfree(), to match ... > @@ -877,6 +873,14 @@ struct domain *domain_create(domid_t domid, > > /* All error paths can depend on the above setup. */ > > + err = -ENOMEM; > + d->console = xvzalloc(typeof(*d->console)); ... this. Sorry, I probably could/should have noticed this earlier. Jan
