On Mon Jun 23, 2025 at 9:31 AM CEST, Jan Beulich wrote: > On 20.06.2025 20:28, Alejandro Vallejo wrote: >> There's the unwritten convention in x86 of splitting type names using >> underscores. Add such convention to the CODINNG_STYLE to make it >> common and less unwritten. > > Just curious: How does x86 come into play here? Xen inherited this un- > written rule from Linux, afaict. > > Jan
x86 follows the rule far more strictly than other Xen ports. Even in Linux it's not uncommon to see some words stashed together because they represent a single concept. e.g: "bootmode", "bootram", "bootmod", "bootaddr", etc. Some of them inherited by Xen itself, like "softirq". But I digress. I mentioned x86 because it's the most traceable use of the rule as written in CODING_STYLE in this patch. When or why you decided to do so is another matter entirely which I very definitely do not know. If you feel the commit message should be something else, I'm happy for it to be such something else. Cheers, Alejandro