On 21.06.2025 04:19, Stefano Stabellini wrote: > On Tue, 10 Jun 2025, Jan Beulich wrote: >> On 06.06.2025 23:04, Stefano Stabellini wrote: >>> --- a/xen/arch/x86/include/asm/cpufeatures.h >>> +++ b/xen/arch/x86/include/asm/cpufeatures.h >>> @@ -1,6 +1,6 @@ >>> -/* >>> - * Explicitly intended for multiple inclusion. >>> - */ >>> +/* This file is intended to be included multiple times. */ >> >> While I can see that this may indeed be needed, ... >> >>> +/*#ifndef X86_CPUFEATURES_H */ >>> +/*#define X86_CPUFEATURES_H */ >> >> ... I wonder what this is about. Sorry, I didn't spot this as a change >> in v3. If it's needed, these comments want to be well formed (have a >> space between * and #). > > Without it, ECLAIR throws other violations. But I can fix the lack of a > space.
So the original comment that was there didn't serve its purpose? >> Beyond this - why is this header ending up different from e.g. >> public/errno.h, where a SAF-8 comment is used? > > Because SAF-8 is meant to be used on top of an #ifndef and there is no > #ifndef here How can that be? SAF-8 is specifically to cover for the lack of a guard, i.e. typically the lack of any (respective) #ifndef. SAF-8's description also says nothing along these lines. And then it looks to be possible to add some #ifndef here, e.g. checking NCAPINTS. Just that the #endif would need to come early, and another #ifndef would then be wanted at about 2/3 of the file. Jan
