On 17.06.2025 19:13, Alejandro Vallejo wrote:
> --- a/xen/include/xen/device_tree.h
> +++ b/xen/include/xen/device_tree.h
> @@ -261,10 +261,21 @@ void intc_dt_preinit(void);
> /* Helper to read a big number; size is in cells (not bytes) */
> static inline u64 dt_read_number(const __be32 *cell, int size)
> {
> - u64 r = 0;
> + u64 r = be32_to_cpu(*cell);
> +
> + switch ( size )
> + {
> + case 1:
> + break;
> + case 2:
> + r = (r << 32) | be32_to_cpu(cell[1]);
> + break;
> + default:
> + // Nonsensical size. default to 1.
> + printk(XENLOG_WARNING "dt_read_number(%d) bad size\n", size);
Might be good to entirely unambiguously indicate it's the 2nd argument.
Iirc an approach we use elsewhere is to spell it dt_read_number(,%d).
Jan
