On 17.06.2025 11:48, Jan Beulich wrote: > On 17.06.2025 03:27, dm...@proton.me wrote: >> From: Denis Mukhin <dmuk...@ford.com> >> >> Introduce domain_console for grouping data structures used for integrating >> domain's diagnostic console with Xen's console driver. >> >> Group all pbuf-related data structures under domain_console. Rename the moved >> fields to plain .buf, .idx and .lock names, since all uses of the fields are >> touched. >> >> Bump the domain console buffer size to the closest power of 2 (256) and >> rename the symbol to DOMAIN_CONSOLE_BUF_SIZE. >> >> Move d->console->buf management under CONFIG_VERBOSE_DEBUG when the >> HYPERCALL_console_io handler is enabled. > > This, if at all, needs to be a separate change (with its own justification). > I for one don't think VERBOSE_DEBUG is intended to control any kind of guest > output.
Hmm, the option's help text indeed says it mixes two unrelated things. Maybe this wants untangling. With a behavioral change like the one you suggest, that help text would need updating in any event, though. Jan