Hi Michal,
> On 17 Jun 2025, at 08:19, Michal Orzel <michal.or...@amd.com> wrote:
>
> Commit f6d1bfa16052 introduced flushing conring in console_init_preirq().
> However, when CONFIG_EARLY_PRINTK is enabled, the early boot messages
> had already been sent to serial before main console initialization. This
> results in all the early boot messages being duplicated.
>
> Change conring_flush() to accept argument listing devices to which to
> flush conring. We don't want to send to serial at console initialization
> when using early printk, but we want these messages to be send at conring
NIT: s/send/sent/
> dump triggered by keyhandler.
>
> Fixes: f6d1bfa16052 ("xen/console: introduce conring_flush()")
> Signed-off-by: Michal Orzel <michal.or...@amd.com>
> ---
> xen/drivers/char/console.c | 20 ++++++++++++++------
> 1 file changed, 14 insertions(+), 6 deletions(-)
>
This LGTM, I’ve also tested with fvp-base for arm64 with CONFIG_EARLY_PRINTK.
Reviewed-by: Luca Fancellu <luca.fance...@arm.com>
Tested-by: Luca Fancellu <luca.fance...@arm.com>
Cheers,
Luca
