On 13.06.2025 17:13, Alejandro Vallejo wrote: > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -14,6 +14,7 @@ config CORE_PARKING > > config DOM0LESS_BOOT > bool "Dom0less boot support" if EXPERT > + select LIBFDT > depends on HAS_DOM0LESS && HAS_DEVICE_TREE && DOMAIN_BUILD_HELPERS > default y > help
Nit: Imo it is good practice to have the select-s after the "depends on", and perhaps also after any default(s). > --- a/xen/common/Makefile > +++ b/xen/common/Makefile > @@ -8,7 +8,7 @@ obj-y += cpu.o > obj-$(CONFIG_DEBUG_TRACE) += debugtrace.o > obj-$(CONFIG_HAS_DEVICE_TREE) += device.o > obj-$(filter-out $(CONFIG_X86),$(CONFIG_ACPI)) += device.o > -obj-$(CONFIG_HAS_DEVICE_TREE) += device-tree/ > +obj-$(firstword $(CONFIG_HAS_DEVICE_TREE) $(CONFIG_DOM0LESS_BOOT)) += > device-tree/ Why not obj-$(CONFIG_HAS_DEVICE_TREE) += device-tree/ obj-$(CONFIG_DOM0LESS_BOOT) += device-tree/ as we have it in a few similar situations? And why would the duplication be needed in the first place? Shouldn't DOM0LESS_BOOT imply HAS_DEVICE_TREE? Sadly the description once again only says what is intended, but not why. And the dependency is actually visible in patch context above, in the hunk altering xen/common/Kconfig. Jan
