On 13.06.2025 17:17, Stewart Hildebrand wrote: > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -8,6 +8,8 @@ config ARM_64 > depends on !ARM_32 > select 64BIT > select HAS_FAST_MULTIPLY > + select HAS_VPCI_GUEST_SUPPORT if PCI_PASSTHROUGH > + select HAS_PASSTHROUGH if PCI_PASSTHROUGH
Seeing this, I like this as little as I liked ... > @@ -258,6 +260,12 @@ config PARTIAL_EMULATION > > source "arch/arm/firmware/Kconfig" > > +config PCI_PASSTHROUGH > + bool "PCI passthrough" if EXPERT > + depends on ARM_64 ... the form with the select-s put here. I'll (obviously) leave it to the Arm maintainers to judge, but my recommendation would be to simply drop this patch. As per the description it's merely "make it easier ...", which imo doesn't warrant such an abuse of HAS_*. As a nit: The select-s also would better be sorted alphabetically. Jan
