On 28.05.2025 11:16, Penny Zheng wrote: > From: Stefano Stabellini <stefano.stabell...@amd.com> > > We introduce a new Kconfig CONFIG_SYSCTL, which shall only be disabled > on some dom0less systems or PV shim on x86, to reduce Xen footprint. > > Making SYSCTL without prompt is transient and it will be fixed in the final
Nit: s/fixed/adjusted/ ? It's not a bug, after all. > patch. Also, we will also state unsetting SYSCTL in pvshim_defconfig to > explicitly make it unavailable for PV shim in the final patch. Even without the double "also" this reads odd. But it's also unclear what it has to do here, nor whether what is being said is actually correct. > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -579,4 +579,15 @@ config BUDDY_ALLOCATOR_SIZE > Amount of memory reserved for the buddy allocator to serve Xen heap, > working alongside the colored one. > > +menu "Supported hypercall interfaces" > + visible if EXPERT > + > +config SYSCTL > + bool "Enable sysctl hypercall" > + def_bool y Why def_bool when you already have bool on the earlier line? > + help > + This option shall only be disabled on some dom0less systems, > + to reduce Xen footprint. This isn't overly useful (but possibly misleading) as long as the prompt isn#t going to be visible, yet. > +endmenu Blank line please ahead of this one. Jan
