On 02/06/2025 2:46 pm, Kevin Lampis wrote: > From: Ross Lagerwall <ross.lagerw...@citrix.com> > > Also cache it to avoid needing to repeatedly ask the firmware. > > Signed-off-by: Ross Lagerwall <ross.lagerw...@citrix.com> > Signed-off-by: Kevin Lampis <kevin.lam...@cloud.com>
You must CC the maintainers on patches. If in doubt, use ./scripts/get_maintainer.pl. > diff --git a/xen/common/efi/runtime.c b/xen/common/efi/runtime.c > index 7e1fce291d..b63d21f16c 100644 > --- a/xen/common/efi/runtime.c > +++ b/xen/common/efi/runtime.c > @@ -40,6 +40,9 @@ void efi_rs_leave(struct efi_rs_state *state); > unsigned int __read_mostly efi_num_ct; > const EFI_CONFIGURATION_TABLE *__read_mostly efi_ct; > > +#if defined(CONFIG_X86) && !defined(CONFIG_PV_SHIM) > +bool __ro_after_init efi_secure_boot; > +#endif This doesn't build on ARM arch/arm/efi/boot.c: In function ‘init_secure_boot_mode’: arch/arm/efi/boot.c:888:25: error: lvalue required as left operand of assignment 888 | efi_secure_boot = false; | ^ arch/arm/efi/boot.c:891:25: error: lvalue required as left operand of assignment 891 | efi_secure_boot = true; | ^ make[3]: *** [Rules.mk:249: arch/arm/efi/boot.o] Error 1 I also don't see an answer to why there's a CONFIG_PV_SHIM special case. Shim has nothing to do with this. ~Andrew
