On 28.05.2025 00:39, Andrew Cooper wrote:
> On 27/05/2025 11:37 pm, Jason Andryuk wrote:
>> is_periodic_irq() was removed in the Fixes commit, but the prototype
>> remained. Drop it now.
>>
>> Fixes: ddc35d1cc994 ("[HVM] Enable more than one platform timer...")
>> Signed-off-by: Jason Andryuk <[email protected]>
>
> Acked-by: Andrew Cooper <[email protected]>
>
>> ---
>> The full Fixes line is:
>> Fixes: ddc35d1cc994 ("[HVM] Enable more than one platform timer
>> (PIT/RTC/HPET) programmed as periodic timer and adds them to abstract layer,
>> which keeps track of pending_intr_nr to avoid time interrupt lost and
>> sync'ed timer with TSC.")
>
> Yeah, the older commit messages weren't as well structured as we insist
> on them being these days.
>
> How did you find this? inspection, or a tool?
What I'm curious about: Why didn't Eclair spot this?
Jan
