On 27/05/2025 5:17 pm, Mykola Kvach wrote: > Hi, @Andrew Cooper > > On Tue, May 27, 2025 at 3:53 PM Andrew Cooper <andrew.coop...@citrix.com> > wrote: >> On 27/05/2025 11:04 am, Mykola Kvach wrote: >>> From: Mykola Kvach <mykola_kv...@epam.com> >>> >>> The scheduler_disable and scheduler_enable calls have been removed >>> from freeze_domains and thaw_domains, respectively, and relocated >>> to their usage context in enter_state. This change addresses >>> the concern about misleading function semantics, as the scheduler >>> operations are not directly related to the domain pausing/resuming >>> implied by the freeze/thaw naming. >>> >>> Suggested-by: Jan Beulich <jbeul...@suse.com> >>> Signed-off-by: Mykola Kvach <mykola_kv...@epam.com> >> FYI I've kicked off a run with this patch: >> >> https://gitlab.com/xen-project/hardware/xen-staging/-/pipelines/1838715729 >> >> which includes the real suspend/resume testing on several pieces of >> hardware. > It appears I made a mistake by failing to mark this patch as > containing only non-functional changes.
x86 suspend/resume is sufficiently fragile that you only have to threaten a change for something to break. But yes, "No functional change." goes a long way towards helping the reviewer. ~Andrew
