On 09/04/2025 2:17 pm, Jan Beulich wrote: > First gfn can be set just once, rather than (conditionally) twice.
This wants a comma after First, or you're implying "the first gfn can be..." which not the meaning you're trying to convey. You also don't really want one before "rather". > And then gfn can be used in two function calls, rather than re- > calculating the value there. > > Signed-off-by: Jan Beulich <jbeul...@suse.com> Acked-by: Andrew Cooper <andrew.coop...@citrix.com> > --- > I wasn't quite sure about continuing to use an open-coded shift. > PFN_DOWN() could be used, or paddr_to_pfn(). Neither looks to be an > overly good fit to translate a gaddr to a gfn, yet gaddr_to_gfn() can't > be used quite nicely either as long as gfn isn't of type gfn_t. I think it wants to stay like this here.
