On 07/04/2025 8:26 am, Jan Beulich wrote:
> On 06.04.2025 13:36, scan-ad...@coverity.com wrote:
>> Hi,
>>
>> Please find the latest report on new defect(s) introduced to XenProject
>> found with Coverity Scan.
>>
>> 1 new defect(s) introduced to XenProject found with Coverity Scan.
>>
>>
>> New defect(s) Reported-by: Coverity Scan
>> Showing 1 of 1 defect(s)
>>
>>
>> ** CID 1645644: Control flow issues (UNREACHABLE)
>> /xen/arch/x86/hvm/vmx/vmcs.c: 774 in _vmx_cpu_up()
>>
>>
>> ________________________________________________________________________________________________________
>> *** CID 1645644: Control flow issues (UNREACHABLE)
>> /xen/arch/x86/hvm/vmx/vmcs.c: 774 in _vmx_cpu_up()
>> 768 vpid_sync_all();
>> 769
>> 770 vmx_pi_per_cpu_init(cpu);
>> 771
>> 772 return 0;
>> 773
>>>>> CID 1645644: Control flow issues (UNREACHABLE)
>>>>> This code cannot be reached: "vmxon_fault:
>> if (bios_locke...".
>> 774 vmxon_fault:
>> 775 if ( bios_locked &&
>> 776 test_bit(X86_FEATURE_SMX, &boot_cpu_data.x86_capability) &&
>> 777 (!(eax & IA32_FEATURE_CONTROL_ENABLE_VMXON_OUTSIDE_SMX) ||
>> 778 !(eax & IA32_FEATURE_CONTROL_ENABLE_VMXON_INSIDE_SMX)) )
>> 779 {
> Is this perhaps an indication that Coverity doesn't understand asm goto()?
Yes. That's a false positive.
~Andrew
