On 19/03/2025 11:24 am, Jan Beulich wrote:
> From: Ahmed S. Darwish <da...@linutronix.de>
>
> CPUID leaf 0x2 emits one-byte descriptors in its four output registers
> EAX, EBX, ECX, and EDX. For these descriptors to be valid, the most
> significant bit (MSB) of each register must be clear.
>
> Leaf 0x2 parsing at intel.c only validated the MSBs of EAX, EBX, and
> ECX, but left EDX unchecked.
>
> Validate EDX's most-significant bit as well.
>
> Fixes: 1aa6feb63bfd ("Port CPU setup code from Linux 2.6")
> Signed-off-by: Ahmed S. Darwish <da...@linutronix.de>
> Signed-off-by: Ingo Molnar <mi...@kernel.org>
> Link: https://lore.kernel.org/r/20250304085152.51092-3-da...@linutronix.de
>
> Use ARRAY_SIZE() though.
>
> Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> 1881148215c6
> Signed-off-by: Jan Beulich <jbeul...@suse.com>
Acked-by: Andrew Cooper <andrew.coop...@citrix.com>
> ---
> I wasn't really convinced that we strictly need f6bdaab79ee4 ("x86/cpu:
> Properly parse CPUID leaf 0x2 TLB descriptor 0x63") as well. Thoughts?
I don't think we need it either.
