On 10/04/2025 11:07 am, Anthony PERARD wrote: > On Wed, Apr 09, 2025 at 05:36:58PM +0100, Andrew Cooper wrote: >> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml >> index 36ec6a7e1ee5..5a0a853e551d 100644 >> --- a/.gitlab-ci.yml >> +++ b/.gitlab-ci.yml >> @@ -1,12 +1,19 @@ >> +variables: >> + REGISTRY: registry.gitlab.com/xen-project/hardware/test-artifacts > Did you consider naming that variable XEN_REGISTRY like in the xen.git > repo? REGISTRY is a fine name too.
I did, except the makefile for rebuilding takes REGISTRY, so this removes a REGISTERY=$XEN_REGISTRY from the container rebuild logic. Which is another thing I haven't posted, because it turns out our docker-in-docker only works for x86, not for ARM. > >> + >> workflow: >> - name: "xen test artifacts" >> + name: "Xen test artifacts" > Isn't this a very useless workflow:name? Can I suggest to remove it > instead? I mean, currently, all pipeline appear to do the same thing: > > https://gitlab.com/xen-project/hardware/test-artifacts/-/pipelines > > Without "workflow:name" set, the default name will be the subject of the > top commit. I did wonder about the utility of it. I'll drop. ~Andrew
