On 09.04.2025 00:40, dm...@proton.me wrote:
> From: Denis Mukhin <dmuk...@ford.com>
>
> Use %pd in all logs issued from arch_domain_create() and reword some of the
> messages.
>
> Also, expand error message in arch_domain_create() under !emulation_flags_ok()
> case to help debugging.
>
> Signed-off-by: Denis Mukhin <dmuk...@ford.com>
Somewhat reluctantly:
Acked-by: Jan Beulich <jbeul...@suse.com>
It still remains unclear to me why you think you need to change aspects of
prior wording for no apparent reason. For example, ...
> --- a/xen/arch/x86/domain.c
> +++ b/xen/arch/x86/domain.c
> @@ -791,13 +791,14 @@ int arch_domain_create(struct domain *d,
> {
> if ( !opt_allow_unsafe )
> {
> - printk(XENLOG_G_ERR "Xen does not allow DomU creation on this
> CPU"
> - " for security reasons.\n");
> + printk(XENLOG_G_ERR
> + "%pd: will not create domU on this CPU for security
> reasons\n",
> + d);
... why would "DomU" need to change to "domU"? Yes, we're inconsistent about
the case of the first letter. Yet the change here doesn't help the
inconsistency in any way. My more general request remains, going forward:
Please no changes, big or small, that don't have at least a tiny bit of a
reason.
Jan
