Hi Michal,
On 07/04/2025 10:04, Orzel, Michal wrote:
On 03/04/2025 19:12, Ayan Kumar Halder wrote:
Added a new file prepare_xen_region.inc to hold the common earlyboot MPU regions
configurations across arm64 and arm32.
prepare_xen_region, fail_insufficient_regions() will be used by both arm32 and
arm64. Thus, they have been moved to prepare_xen_region.inc.
enable_secondary_cpu_mm() is a stub which is moved to prepare_xen_region.inc as
SMP is currently not supported for MPU.
This does not sound right. If you want a place to keep some common MPU stuff
between Arm64 and Arm32, you need to come up with better name for a file. SMP
has nothing to do here with preparing regions so it feels odd to have
enable_secondary_cpu_mm stub there.
Can I rename prepare-xen-region.inc to mpu.inc ?
Julien/Luca - any thoughts ?
Also, new files should use dashes '-' and not underscores '_'.
Ack
- Ayan
~Michal
