On 07/07/2018 12:05 PM, Paul Durrant wrote: > Turn iommu_map/unmap_page() into straightforward wrappers that check the > existence of the relevant iommu_op and call through to it. This makes them > usable by PV IOMMU code to be delivered in future patches. > Leave the decision on whether to invoke domain_crash() up to the caller. > This has the added benefit that the (module/line number) message that > domain_crash() spits out will be more indicative of where the problem lies. > > NOTE: This patch includes one bit of clean-up in set_identity_p2m_entry() > replacing use of p2m->domain with the domain pointer passed into the > function. > > Signed-off-by: Paul Durrant <[email protected]>
I have some minor reservations about this, since it could leave open the possibility that a failed operation *doesn't* result in a domain crash when it should. But all the functions in question are __must_check, so the risk of that sort of bug creeping in is significantly lower. So: Reviewed-by: George Dunlap <[email protected]> _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
