On 18/03/2025 3:04 pm, Jan Beulich wrote: > On 17.03.2025 20:20, Andrew Cooper wrote: >> Move the declaration from asm/system.h into asm/traps.h. >> >> No functional change. >> >> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > Acked-by: Jan Beulich <jbeul...@suse.com>
Thanks. > >> --- a/xen/arch/x86/traps-setup.c >> +++ b/xen/arch/x86/traps-setup.c >> @@ -3,5 +3,20 @@ >> * Configuration of event handling for all CPUs. >> */ >> #include <asm/idt.h> >> +#include <asm/msr.h> >> +#include <asm/system.h> >> +#include <asm/traps.h> >> >> DEFINE_PER_CPU_READ_MOSTLY(idt_entry_t *, idt); >> + >> +/* >> + * Set up per-CPU linkage registers for exception, interrupt and syscall >> + * handling. >> + */ >> +void percpu_traps_init(void) >> +{ >> + subarch_percpu_traps_init(); > At some point this may then want expanding into here, seeing that we don't > have any subarch anymore, and don't expect to re-gain one any time soon? I have folded it later in the FRED series. This, and load_system_tables() need non-trivial alterations to support FRED, and I haven't got that part of the work cleaned up suitable to post yet. ~Andrew