On 02.04.2025 11:52, Andrew Cooper wrote: > On 02/04/2025 10:40 am, Jan Beulich wrote: >> On 02.04.2025 01:34, Andrew Cooper wrote: >>> With the new toolchain baseline, we can make use of asm goto() in certain >>> places, and the VMXON invocation is one example. >>> >>> This removes the logic to set up rc (including a fixup section where >>> bactraces >>> have no connection to the invoking function), the logic to decode it, and >>> the >>> default case which was dead but in a way the compiler couldn't prove >>> previously. >>> >>> No functional change. >>> >>> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> >>> --- >>> CC: Jan Beulich <jbeul...@suse.com> >>> CC: Roger Pau Monné <roger....@citrix.com> >>> CC: dm...@proton.me >>> >>> RFC. To be rebased over Denis' general cleanup. >> LGTM. Can't this actually replace some of his cleanup? Judging from >> base-commit: at the bottom this isn't based on his work. In which case: >> Reviewed-by: Jan Beulich <jbeul...@suse.com> > > Oh. I was expecting there to be far more debate on this.
You had indicated many times that you want to make use of asm goto(), and for situation like the one here I'm actually in trouble seeing any objections you might have been expecting. Were you maybe expecting me to object just for the purpose of objecting ;-) ? Jan
