On 07/07/2018 12:05 PM, Paul Durrant wrote: > ...rather than more ambiguous term 'frame'. > > There are many places in the grant table code that use a variable or > field name '.*frame' to refer to a quantity that is strictly an MFN, and > even has type mfn_t. > This patch is a purely cosmetic patch that substitutes 'frame' with 'mfn' > in those places to make the purpose of the variable or field name more > obvious. > > Signed-off-by: Paul Durrant <[email protected]>
Looks good. One minor comment... > @@ -2320,7 +2320,7 @@ release_grant_for_copy( > struct grant_table *rgt = rd->grant_table; > grant_entry_header_t *sha; > struct active_grant_entry *act; > - mfn_t r_frame; > + mfn_t mfn; > uint16_t *status; > grant_ref_t trans_gref; > struct domain *td; If you end up respinning this, you might consider making this 'rmfn' or somethign, just because everything in this function seems to have the 'r' prefix. But either way: Reviewed-by: George Dunlap <[email protected]> _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
