On 28.03.2025 18:36, Andrew Cooper wrote: > In a 64bit-clean environment, blowfish fails: > > make[6]: Leaving directory > '/builddir/build/BUILD/xen-4.19.1/tools/tests/x86_emulator' > In file included from /usr/include/features.h:535, > from /usr/include/bits/libc-header-start.h:33, > from /usr/include/stdint.h:26, > from > /usr/lib/gcc/x86_64-xenserver-linux/12/include/stdint.h:9, > from blowfish.c:18: > /usr/include/gnu/stubs.h:7:11: fatal error: gnu/stubs-32.h: No such > file or directory > 7 | # include <gnu/stubs-32.h> > | ^~~~~~~~~~~~~~~~ > compilation terminated. > make[6]: *** [testcase.mk:15: blowfish.bin] Error 1 > > because of lack of glibc-i386-devel or equivelent. It's non-fatal, but > reduces the content in test_x86_emulator, which we do care about running. > > Instead, convert all emulator testcases to being freestanding builds, resuing > the tools/firmware/include/ headers. > > This in turn requires making firmware's stdint.h compatible with 64bit builds. > We now have compiler types for every standard type we use. > > Suggested-by: Jan Beulich <jbeul...@suse.com> > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
Reviewed-by: Jan Beulich <jbeul...@suse.com>
