On 28.03.2025 14:44, Andrew Cooper wrote: > From: Lin Liu <lin....@citrix.com> > > In divmod.c, additionally swap xen/lib.h for xen/macros.h as only ABS() is > needed. > > In find-next-bit.c, ext2 has nothing to do with this logic.
While I agree here, ... > Despite the > comments, it was a local modification when the logic was imported from Linux, > because Xen didn't have a suitable helper. ... I certainly can see functions of these names in Linux 2.6.16. Just in the PA-RISC bitops.h, though. Yet this may be an indication that yet earlier on this was a wider thing there. > The new infrsatructure does have a suitable primitive, so use it. > > No functional change. > > Signed-off-by: Lin Liu <lin....@citrix.com> Missing your own S-o-b? Reviewed-by: Jan Beulich <jbeul...@suse.com> Jan