On 18.03.2025 16:30, Andrii Sultanov wrote: > --- a/xen/drivers/passthrough/amd/iommu_acpi.c > +++ b/xen/drivers/passthrough/amd/iommu_acpi.c > @@ -707,8 +707,8 @@ static int __init cf_check parse_ivrs_ioapic(const char > *str) > } > } > > - ioapic_sbdf[idx].bdf = PCI_BDF(bus, dev, func); > - ioapic_sbdf[idx].seg = seg; > + ioapic_sbdf[idx].sbdf.bdf = PCI_BDF(bus, dev, func); > + ioapic_sbdf[idx].sbdf.seg = seg;
Use PCI_SBDF() and a single assignment? > @@ -734,8 +734,8 @@ static int __init cf_check parse_ivrs_hpet(const char > *str) > return -EINVAL; > > hpet_sbdf.id = id; > - hpet_sbdf.bdf = PCI_BDF(bus, dev, func); > - hpet_sbdf.seg = seg; > + hpet_sbdf.sbdf.bdf = PCI_BDF(bus, dev, func); > + hpet_sbdf.sbdf.seg = seg; Same here? And apparently similar for most/all further changes in the changes to this file? Jan
