On 19.03.2025 00:37, dm...@proton.me wrote:
> +/*
> + * Switch console focus.
> + * Rotates input focus among Xen, dom0 and boot-time created domUs while
> + * skipping switching serial input to non existing domains.
> + */
> +static void console_switch_focus(void)
> +{
> + const domid_t n = domid_top + 1;
The use of this renamed identifier is now in sharp conflict with the comment,
talking about boot-time created domains only.
> + domid_t i = ( console_focus == DOMID_XEN )
> + ? get_initial_domain_id() : console_focus + 1;
> +
> + for ( ; i < n; i++ )
> + if ( !console_set_focus(i) )
This being the sole call caring about the function's return value, why isn't
the function returning a mere boolean?
Jan
