[Public] Hi
> -----Original Message----- > From: Jan Beulich <jbeul...@suse.com> > Sent: Monday, March 24, 2025 11:12 PM > To: Penny, Zheng <penny.zh...@amd.com> > Cc: Huang, Ray <ray.hu...@amd.com>; Andrew Cooper > <andrew.coop...@citrix.com>; Roger Pau Monné <roger....@citrix.com>; > Anthony PERARD <anthony.per...@vates.tech>; Orzel, Michal > <michal.or...@amd.com>; Julien Grall <jul...@xen.org>; Stefano Stabellini > <sstabell...@kernel.org>; xen-devel@lists.xenproject.org > Subject: Re: [PATCH v3 04/15] xen/cpufreq: move XEN_PROCESSOR_PM_xxx > to internal header > > On 06.03.2025 09:39, Penny Zheng wrote: > > XEN_PROCESSOR_PM_xxx are used to set xen_processor_pmbits only, which > > is a Xen-internal variable only. Although PV Dom0 passed these bits in > > si->flags, they haven't been used anywhere. > > Please be careful with "not used anywhere". See e.g. > https://xenbits.xen.org/gitweb/?p=legacy/linux-2.6.18- > xen.git;a=blob;f=arch/i386/kernel/acpi/processor_extcntl_xen.c;h=eb6a53e9572c13 > 7da505a7d4970b1a5b7e1c522d;hb=HEAD#l193 > > > So this commit moves XEN_PROCESSOR_PM_xxx back to internal header > > "acpi/cpufreq/processor_perf.h" > > Essentially you're again altering the stable public ABI in a way that's not > acceptable. > Understood... I misunderstood the previous comment again... I'll only move the new XEN_PROCESSOR_PM_CPPC into the internal header > Jan
