On 06.03.2025 09:39, Penny Zheng wrote: > --- a/xen/drivers/cpufreq/cpufreq.c > +++ b/xen/drivers/cpufreq/cpufreq.c > @@ -353,7 +353,13 @@ int cpufreq_add_cpu(unsigned int cpu) > if (hw_all || (cpumask_weight(cpufreq_dom->map) == > pmpt->domain_info.num_processors)) { > memcpy(&new_policy, policy, sizeof(struct cpufreq_policy)); > - policy->governor = NULL; > + > + /* > + * Only when cpufreq_driver.setpolicy == NULL, we need to deliberately > + * set old gov as NULL to trigger the according gov starting. > + */ > + if ( cpufreq_driver.setpolicy == NULL ) > + policy->governor = NULL; > > cpufreq_cmdline_common_para(&new_policy);
Indentation looks off-by-1 here. Also (I may have asked this before, but couldn't find an indication in this submission, including in the cover letter): Is this independent of all earlier patches in the series, and could hence go in right away? Jan