On 21.03.2025 18:13, Andrew Cooper wrote: > On 17/03/2025 11:42 am, Jan Beulich wrote: >> On 11.03.2025 22:10, Andrew Cooper wrote: >>> --- a/xen/include/xlat.lst >>> +++ b/xen/include/xlat.lst >>> @@ -34,8 +34,6 @@ >>> ? pmu_intel_ctxt arch-x86/pmu.h >>> ? pmu_regs arch-x86/pmu.h >>> >>> -! cpu_user_regs arch-x86/xen-@arch@.h >> Maybe worthwhile to keep the line, just switching ! to #, in order to >> indicate the type isn't accidentally missing here? > > Is it really worth it? That's a new semantic to an opaque > domain-specific-language, and this file only ever gets looked at when > something is broken.
True. Yet how else would we distinguish accidentally missing from deliberately omitted? Jan
