On Mon, 17 Mar 2025, Roger Pau Monne wrote: > Move the current logic to use the matrix keyword to generate a task for > each version of FreeBSD we want to build Xen on. The matrix keyword > however cannot be used in YAML aliases, so it needs to be explicitly used > inside of each task, which creates a bit of duplication. At least abstract > the FreeBSD minor version numbers to avoid repetition of image names. > > Note that the full build uses matrix over an env variable instead of using > it directly in image_family. This is so that the alias can also be set > based on the FreeBSD version, in preparation for adding further tasks that > will depend on the full build having finished. > > Signed-off-by: Roger Pau Monné <roger....@citrix.com> > --- > I could alternatively name FREEBSD_15 FREEBSD_CURRENT or FREEBSD_HEAD or > something versionless, however I don't know about the other versions. > > Assuming there will only be 3 versions tested at all times I could use: > FREEBSD_HEAD, FREEBSD_PRODUCTION and FREEBSD_LEGACY, as to avoid having to > specify versions in the task definitions.
I think it is OK but I'll leave it to others to comment as well Acked-by: Stefano Stabellini <sstabell...@kernel.org>
