Re: [PATCH 15/23] xen/xsm: Add XSM_HW_PRIV

[Jan Beulich]

On 06.03.2025 23:03, Jason Andryuk wrote:
> --- a/xen/include/xsm/dummy.h
> +++ b/xen/include/xsm/dummy.h
> @@ -95,7 +95,11 @@ static always_inline int xsm_default_action(
>              return 0;
>          fallthrough;
>      case XSM_PRIV:
> -        if ( is_control_domain(src) )
> +    case XSM_HW_PRIV:
> +        if ( is_control_domain(src) && action != XSM_HW_PRIV )
> +            return 0;
> +        if ( is_hardware_domain(src) &&
> +             (action == XSM_HW_PRIV || action == XSM_DM_PRIV) )
>              return 0;
>          return -EPERM;

Hmm. Isn't DM_PRIV a property applying to the control domain (besides
any stub domains), but not the hardware one?

Jan