On 13/03/2025 1:55 pm, Jan Beulich wrote:
> For one there's no need for each architecture to have the same logic.
> Move to the root Makefile, also to calculate just once.
>
> And then re-arrange to permit FAST_SYMBOL_LOOKUP to be independent of
> LIVEPATCH, which may be useful in (at least) debugging.
>
> Signed-off-by: Jan Beulich <jbeul...@suse.com>
> ---
> Likely syms-warn-dup-y wants to follow suit; it doesn't even have an Arm
> counterpart right now.
Recently, I thought the same about --orphan-handling={warn,error} too.
We need to up it to error, and enforce it consistently.
There's actually a lot of $(TARGET)-syms which ought to be less
copy&paste. I'll submit my cleanup so far, which doesn't interact here
I don't think, but is also incomplete.
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -460,6 +460,10 @@ ALL_OBJS-$(CONFIG_CRYPTO) += crypto/buil
>
> ALL_LIBS-y := lib/lib.a
>
> +all-symbols-y :=
> +all-symbols-$(CONFIG_LIVEPATCH) += --all-symbols
> +all-symbols-$(CONFIG_FAST_SYMBOL_LOOKUP) += --sort-by-name
> +
I presume this works, so it's after we've processed Kconfig, but is
there really nowhere better for it to live?
If we're moving others, this is going to turn into a lot, and it's
specific to one final stage.
~Andrew
