On 11/03/2025 7:48 pm, Julien Grall wrote: > Hi, > > On 05/03/2025 00:17, Stefano Stabellini wrote: >> On Tue, 4 Mar 2025, Andrew Cooper wrote: >>> The use of "legitimately" mixes the concepts of "it was designed to >>> do this" >>> and "it was correct to do this". >>> >>> The latter in particular can go stale. "intended" is a better way >>> of phrasing >>> this. >>> >>> No functional change. >>> >>> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> >> > > Reviewed-by: Stefano Stabellini <sstabell...@kernel.org>
Thanks. > > Going through my email, I noticed this patch was not committed. I > wonder if there was any reason? Urgh, it was supposed to go in ahead of 3da2149cf4dc6 ("x86/IDT: Generate bsp_idt[] at build time") which uses the new format. Also ahead of XSN-2, although the part needing this has been deferred for the meantime. But eclair is still non-blocking on D4.10, hence why staging is happy. I'll pick this up in my next sweep. ~Andrew