On 10.03.2025 09:17, Juergen Gross wrote: > On 10.03.25 09:01, Jan Beulich wrote: >> On 06.03.2025 23:03, Jason Andryuk wrote: >>> + shared_entry_v1(gt, idx).flags = flags; >>> + shared_entry_v1(gt, idx).domid = be_domid; >>> + shared_entry_v1(gt, idx).frame = frame; >>> +} >> >> In common code there shouldn't be an assumption that gnttab v1 is in use. > > But isn't the grant table in V1 format until the guest potentially switches > to V2?
Strictly speaking it's in v0 format initially. But yes, I see your point. Provided this function is made clear that it may only ever be used on a domain that wasn't started yet (perhaps proven by way of an assertion). Jan
