On 06.03.2025 00:24, Stefano Stabellini wrote: > On Wed, 5 Mar 2025, Jan Beulich wrote: >> On 25.02.2025 10:38, Nicola Vetrini wrote: >>> Rule 8.2 states: "Function types shall be in prototype form with >>> named parameters". >>> >>> The parameter name is missing from the function pointer type >>> that constitutes the first parameter. >>> >>> No functional change. >>> >>> Signed-off-by: Nicola Vetrini <nicola.vetr...@bugseng.com> >>> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> >>> Reviewed-by: Juergen Gross <jgr...@suse.com> >>> --- >>> Changes in v2: >>> - renamed function parameter name to "elem" >>> - changed prefix to xen/rt since only that scheduler is touched >> >> Looks like you committed v1 of this, and without a maintainer ack? > > Hi Jan, I took Juergen's comment and his maintainer ack, making the > change on commit: https://marc.info/?l=xen-devel&m=173978187314898
Except that aiui Jürgen isn't formally a maintainer of the RT scheduler. Nor did you change the patch subject (as requested by me, and as reflected in v2) to properly express that it's an RT scheduler change (only). (Less formally, with the lack of response by the actual maintainers, taking Jürgen's R-b to fill in for the missing maintainer ack is likely okay, but probably should have been mentioned explicitly. Recurring lack of response by maintainers ought to perhaps result in reconsideration of their maintainership.) Jan
