Hi Michal, > On 3 Mar 2025, at 09:56, Michal Orzel <michal.or...@amd.com> wrote: > > Value stored in size_cells is never read because we're only interested > in retrieving gbase address of shmem region for which we only need > address cells. > > Signed-off-by: Michal Orzel <michal.or...@amd.com> Reviewed-by: Bertrand Marquis <bertrand.marq...@arm.com>
Cheers Bertrand > --- > xen/arch/arm/static-shmem.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/xen/arch/arm/static-shmem.c b/xen/arch/arm/static-shmem.c > index 8f87154c3587..c74fa13d4847 100644 > --- a/xen/arch/arm/static-shmem.c > +++ b/xen/arch/arm/static-shmem.c > @@ -302,7 +302,7 @@ int __init process_shm(struct domain *d, struct > kernel_info *kinfo, > const struct membank *boot_shm_bank; > const struct dt_property *prop; > const __be32 *cells; > - uint32_t addr_cells, size_cells; > + uint32_t addr_cells; > paddr_t gbase, pbase, psize; > int ret = 0; > unsigned int i; > @@ -338,7 +338,6 @@ int __init process_shm(struct domain *d, struct > kernel_info *kinfo, > * pbase is optional. > */ > addr_cells = dt_n_addr_cells(shm_node); > - size_cells = dt_n_size_cells(shm_node); > prop = dt_find_property(shm_node, "xen,shared-mem", NULL); > BUG_ON(!prop); > cells = (const __be32 *)prop->value; > -- > 2.25.1 >
