On 06/07/18 16:29, Jan Beulich wrote:
>>>> On 06.07.18 at 14:37, <andrew.coop...@citrix.com> wrote:
>> This is as the infrastructure appeared in Linux 4.17, adapted slightly for
>> Xen. The architecture independent array_index_mask_nospec() is ported for
>> ARMs benefit, as it currently lacks the optimised version.
>>
>> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
> Acked-by: Jan Beulich <jbeul...@suse.com>
>
> with one question though:
>
>> --- a/xen/include/xen/compiler.h
>> +++ b/xen/include/xen/compiler.h
>> @@ -81,6 +81,10 @@
>> #pragma GCC visibility push(hidden)
>> #endif
>>
>> +/* Make the optimizer believe the variable can be manipulated arbitrarily.
>> */
>> +#define OPTIMIZER_HIDE_VAR(var) \
>> + __asm__ ("" : "=g" (var) : "0" (var))
> Why not a simple "+g" output?
>
> Also I think you want to add blanks inside the parentheses.
Oops - that was insufficient thought when fixing Linux's inefficient
version. Will do both of those, and fold in Julien's ARM changes.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
