On 26.02.2025 18:27, Andrew Cooper wrote: > On 25/02/2025 8:31 am, Jan Beulich wrote: >> On 24.02.2025 17:05, Andrew Cooper wrote: >>> Observant readers may have noticed that the FRED spec has another 8 bits of >>> space reserved immediately following the vector field. >>> >>> Make the existing constant more precise. >>> >>> No functional change. >>> >>> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> >> I don't mind this, so >> Acked-by: Jan Beulich <jbeul...@suse.com> > > Thanks. > >> I can't help the impression though that the majority of places will need >> touching again if vector space was enlarged, to use the alternative larger >> constant then. > > A number of uses don't survive to the end of the series. For the > others, they'll need to become conditional on some new control being > active, so won't be a straight swap for another constant.
Right, that's to be expected. My point though was that the rename (on its own) is perhaps not overly useful in that light. When all the places will need touching again (one way or another) the rename could as well be done when said conditionals are added. But anyway - you have my ack. Jan
