On 26.02.2025 01:50, dm...@proton.me wrote:
> --- a/xen/include/xen/consoled.h
> +++ b/xen/include/xen/consoled.h
> @@ -1,12 +1,34 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> #ifndef __XEN_CONSOLED_H__
> #define __XEN_CONSOLED_H__
>
> #include <public/io/console.h>
>
> +#ifdef CONFIG_PV_SHIM
> +
> void consoled_set_ring_addr(struct xencons_interface *ring);
> struct xencons_interface *consoled_get_ring_addr(void);
> -void consoled_guest_rx(void);
> -void consoled_guest_tx(char c);
> +int consoled_guest_rx(void);
> +int consoled_guest_tx(char c);
> +bool consoled_is_enabled(void);
> +
> +#else
> +
> +static inline int consoled_guest_rx(void)
> +{
> + ASSERT_UNREACHABLE();
> + return -ENODEV;
> +}
Why is this stub needed? The sole caller - afaics - is in
xen/arch/x86/pv/shim.c,
which won't be built when PV_SHIM=n.
Jan
