On 19.02.2025 15:23, Oleksandr Andrushchenko wrote: > On 19.02.25 14:39, Oleksandr Andrushchenko wrote: >> On 17.02.25 12:20, Jan Beulich wrote: >>> On 16.02.2025 11:21, Oleksandr Andrushchenko wrote: >>>> --- a/xen/drivers/char/ns16550.c >>>> +++ b/xen/drivers/char/ns16550.c >>>> @@ -14,7 +14,7 @@ >>>> * abstracted. >>>> */ >>>> #if defined(CONFIG_HAS_PCI) && defined(CONFIG_X86) >>>> -# define NS16550_PCI >>>> +#define NS16550_PCI >>>> #endif >>> Hmm. Either form ought to be okay, so the line would want leaving untouched. > It seems this can actually have 3 forms under IndentPPDirectives control > Please see [1].
I saw that. None of the three variants matches the original above, i.e. here we're again observing a change just for the sake of making a change. The style used is conforming, after all. Jan > I would go with BeforeHash personally > > [1] > https://clang.llvm.org/docs/ClangFormatStyleOptions.html#indentppdirectives > >
