On 13/02/2025 2:26 pm, Oleksii Kurochko wrote: > > > On 2/13/25 3:21 PM, Oleksii Kurochko wrote: >> >> >> On 2/13/25 3:07 PM, Andrew Cooper wrote: >>> On 13/02/2025 1:54 pm, Volodymyr Babchuk wrote: >>>> Hi Andrew, >>>> >>>> Andrew Cooper <andrew.coop...@citrix.com> writes: >>>> >>>>> On 14/01/2025 4:25 am, Volodymyr Babchuk wrote: >>>>>> Volodymyr Babchuk (4): >>>>>> common: remove -fno-stack-protector from EMBEDDED_EXTRA_CFLAGS >>>>>> xen: common: add ability to enable stack protector >>>>>> xen: arm: enable stack protector feature >>>>>> CHANGELOG.md: Mention stack-protector feature >>>>> Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> >>>>> >>>>> There's one minor formatting error which can be fixed on commit. >>>>> >>>>> ~Andrew >>>> Thanks for the review. I noticed that this series is not committed. Is >>>> there anything else required from my side? >>>> >>> You need an ARM Ack on patch 3. [EDIT], no you don't, my R-by is good >>> enough. > Andrew, why it is enough your R-by for patch 3? It seems like it is fully Arm > related patch > and I expect to see Ack from Arm maintainers. Also, there is some comments > from Julien.
Volodymyr is an ARM maintainer (so qualifies for the ARM requirement), and my R-by covers the "looked over by any other person" requirement. ~Andrew
