On 13/02/2025 1:03 pm, Andrii Sultanov wrote: > diff --git a/tools/ocaml/xenstored/process.ml > b/tools/ocaml/xenstored/process.ml > index 432d66321c..cb4efc0fb5 100644 > --- a/tools/ocaml/xenstored/process.ml > +++ b/tools/ocaml/xenstored/process.ml > @@ -437,7 +437,7 @@ let input_handle_error ~cons ~doms ~fct ~con ~t ~req = > | Quota.Limit_reached -> reply_error "EQUOTA" > | Quota.Data_too_big -> reply_error "E2BIG" > | Quota.Transaction_opened -> reply_error "EQUOTA" > - | (Failure "int_of_string") -> reply_error "EINVAL" > + | Utils.ConversionFailed s -> reply_error (Printf.sprintf "EINVAL: > Could not convert '%s' to int" s) > | Define.Unknown_operation -> reply_error "ENOSYS"
Thanks for working on fixing the warning, but this needs to stay reply_error "EINVAL". This is the stringly-typed errno given back to the client, not an arbitrary message to be rendered into the log. ~Andrew
