On 10.02.2025 11:30, Mykyta Poturai wrote:
> --- a/xen/drivers/passthrough/iommu.c
> +++ b/xen/drivers/passthrough/iommu.c
> @@ -20,6 +20,7 @@
> #include <xen/param.h>
> #include <xen/softirq.h>
> #include <xen/keyhandler.h>
> +#include <xen/acpi.h>
> #include <xsm/xsm.h>
>
> #ifdef CONFIG_X86
> @@ -744,6 +745,18 @@ int __init
> iommu_get_extra_reserved_device_memory(iommu_grdm_t *func,
> return 0;
> }
>
> +int iommu_add_pci_sideband_ids(struct pci_dev *pdev)
> +{
> + int ret = -EOPNOTSUPP;
> +
> +#ifdef CONFIG_HAS_PCI
> + if ( acpi_disabled )
> + ret = iommu_add_dt_pci_sideband_ids(pdev);
> +#endif
> +
> + return ret;
> +}
This function has no caller, which violates a Misra rule iirc. Considering
all information given here it's also unclear why it would gain a caller on
x86 (at least as long as DT isn't used there).
Jan
