On 03/02/2025 8:42 am, Jan Beulich wrote: > On 02.02.2025 14:48, Andrew Cooper wrote: >> This removes the unnecessary work of splitting a 32-bit number across >> 4 registers, and recombining later. Bloat-o-meter reports: >> >> add/remove: 0/0 grow/shrink: 0/9 up/down: 0/-295 (-295) >> Function old new delta >> enable_iommu 1748 1732 -16 >> iommu_msi_unmask 98 81 -17 >> iommu_msi_mask 100 83 -17 >> disable_iommu 286 269 -17 >> __msi_set_enable 81 50 -31 >> __pci_disable_msi 178 146 -32 >> pci_cleanup_msi 268 229 -39 >> pci_enable_msi 1063 1019 -44 >> pci_restore_msi_state 1116 1034 -82 >> >> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > Reviewed-by: Jan Beulich <jbeul...@suse.com>
Thanks. > I was actually thinking to do the same. And we have more of such conversions > to be done. Yes. This happened to be an easy one I spotted while reviewing your series, that I could do on the train. AMD IOMMU should move to a pci_sbdf_t too. Right amd_iommu's seg and bdf fields are opposite way to a pci_sbdf_t. But it occurs to me (having just been at a conference where people were asking for easy introductory work), that stuff like this is a good candidate. I'll see about doing a gitlab ticket. ~Andrew
