Hi Michal,

> On 27 Jan 2025, at 10:45, Michal Orzel <michal.or...@amd.com> wrote:
> 
> On Arm32, when CONFIG_PHYS_ADDR_T_32 is set, a build failure is observed:
> arch/arm/platforms/vexpress.c: In function 'vexpress_smp_init':
> arch/arm/platforms/vexpress.c:102:12: error: format '%lx' expects argument of 
> type 'long unsigned int', but argument 2 has type 'long long unsigned int' 
> [-Werror=format=]
>  102 |     printk("Set SYS_FLAGS to %"PRIpaddr" (%p)\n",
> 
> When CONFIG_PHYS_ADDR_T_32 is set, paddr_t is defined as unsigned long.
> Commit 96f35de69e59 dropped __virt_to_maddr() which used paddr_t as a
> return type. Without a cast, the expression type is unsigned long long
> which causes the issue. Fix it.
> 
> Fixes: 96f35de69e59 ("x86+Arm: drop (rename) __virt_to_maddr() / 
> __maddr_to_virt()")
> Signed-off-by: Michal Orzel <michal.or...@amd.com>
> ---

I’ve tested this one and it fix the compilation issue on the above setup, I’ve 
also tested
that it doesn’t introduce issues on other setup (e.g. arm64)

Reviewed-by: Luca Fancellu <luca.fance...@arm.com>
Tested-by: Luca Fancellu <luca.fance...@arm.com>

Reply via email to