On Sat, Jan 25, 2025 at 10:07 AM Borislav Petkov <b...@alien8.de> wrote: > > > On Thu, Jan 23, 2025 at 02:07:36PM -0500, Brian Gerst wrote: > > Instead of having a private area for the stack canary, use > > fixed_percpu_data for GSBASE like the native kernel. > > > > Signed-off-by: Brian Gerst <brge...@gmail.com> > > Reviewed-by: Ard Biesheuvel <a...@kernel.org> > > --- > > arch/x86/platform/pvh/head.S | 15 +++++++++------ > > 1 file changed, 9 insertions(+), 6 deletions(-) > > Use ./scripts/get_maintainer.pl pls. I've added Juergen now. > > > diff --git a/arch/x86/platform/pvh/head.S b/arch/x86/platform/pvh/head.S > > index 4733a5f467b8..fa0072e0ca43 100644 > > --- a/arch/x86/platform/pvh/head.S > > +++ b/arch/x86/platform/pvh/head.S > > @@ -173,10 +173,15 @@ SYM_CODE_START(pvh_start_xen) > > 1: > > UNWIND_HINT_END_OF_STACK > > > > - /* Set base address in stack canary descriptor. */ > > - mov $MSR_GS_BASE,%ecx > > - leal canary(%rip), %eax > > - xor %edx, %edx > > + /* > > + * Set up GSBASE. > > + * Note that, on SMP, the boot cpu uses init data section until > > + * the per cpu areas are set up. > > s/cpu/CPU/g > > check your whole set pls.
To be fair, this was a copy of an existing comment. Is there a style guide where all these grammar rules are documented, so I don't have to keep resending these patches for trivial typos? Brian Gerst
