On 21.01.2025 17:56, Andrew Cooper wrote: > --- a/xen/arch/x86/cpu/intel.c > +++ b/xen/arch/x86/cpu/intel.c > @@ -535,39 +535,49 @@ static void intel_log_freq(const struct cpuinfo_x86 *c) > printk("%u MHz\n", (factor * max_ratio + 50) / 100); > } > > +static void init_intel_perf(struct cpuinfo_x86 *c) > +{ > + uint64_t val; > + unsigned int eax, ver, nr_cnt; > + > + if ( c->cpuid_level <= 9 || > + ({ rdmsrl(MSR_IA32_MISC_ENABLE, val);
Just curious (not an objection or anything): Is there a reason you have two padding blanks here instead of just one? (Really we may want to gain a function-like form to invoke RDMSR, but that's orthogonal to the change here.) Jan